Skip to content

feat(LAB-4038): remove order when creating/updating step and isActivated #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josselinbuils merged 1 commit into from
Dec 3, 2025
Merged

feat(LAB-4038): remove order when creating/updating step and isActivated #1990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/kili/adapters/kili_api_gateway/project_workflow/mappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ def update_step_mapper(data: Union[WorkflowStepCreate, WorkflowStepUpdate]) -> d
"numberOfExpectedLabelsForConsensus": data["number_of_expected_labels_for_consensus"]
if "number_of_expected_labels_for_consensus" in data
else None,
"order": data["order"] if "order" in data else None,
"stepCoverage": data["step_coverage"] if "step_coverage" in data else None,
"type": data["type"] if "type" in data else None,
"assignees": data["assignees"] if "assignees" in data else None,
Expand Down
1 change: 0 additions & 1 deletion src/kili/adapters/kili_api_gateway/project_workflow/operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ def get_update_project_workflow_mutation(fragment: str) -> str:
id
name
type
isActivated
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/kili/adapters/kili_api_gateway/project_workflow/operations_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,4 @@ def get_steps(
f"project ID: {project_id}. The workflow v2 is not activated on this project."
)

return [step for step in steps if step.get("isActivated") is True]
return steps
2 changes: 0 additions & 2 deletions src/kili/domain/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ class WorkflowStepCreate(TypedDict, total=False):
name: Required[str]
consensus_coverage: Optional[int]
number_of_expected_labels_for_consensus: Optional[int]
order: Required[int]
step_coverage: Optional[int]
type: Required[Literal["DEFAULT", "REVIEW"]]
assignees: Required[list[str]]
Expand All @@ -45,7 +44,6 @@ class WorkflowStepUpdate(TypedDict, total=False):
name: Optional[str]
consensus_coverage: Optional[int]
number_of_expected_labels_for_consensus: Optional[int]
order: Optional[int]
step_coverage: Optional[int]
type: Optional[Literal["DEFAULT", "REVIEW"]]
assignees: Optional[list[str]]
Expand Down