Skip to content

🚨 [security] Update rails: 5.2.1 → 5.2.1.1 (minor) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

🚨 [security] Update rails: 5.2.1 → 5.2.1.1 (minor) #14

wants to merge 1 commit into from

Conversation

@depfu
Copy link
Contributor

@depfu depfu bot commented Nov 28, 2018

🚨 Your version of rails has known security vulnerabilities 🚨

Advisory: CVE-2018-16476
Disclosed: November 27, 2018
URL: https://groups.google.com/forum/#!topic/rubyonrails-security/FL4dSdzr2zw

ActiveJob/ActiveStorage vulnerabilities

There is a vulnerability in Active Job. This vulnerability has been
assigned the CVE identifier CVE-2018-16476.

Versions Affected: >= 4.2.0
Not affected: < 4.2.0
Fixed Versions: 4.2.11, 5.0.7.1, 5.1.6.1, 5.2.1.1

Impact

Carefully crafted user input can cause Active Job to deserialize it using GlobalId
and allow an attacker to have access to information that they should not have.

Vulnerable code will look something like this:

MyJob.perform_later(user_input)

All users running an affected release should either upgrade or use one of the
workarounds immediately.

There is a vulnerability in Active Storage. This vulnerability has been
assigned the CVE identifier CVE-2018-16477.

Versions Affected: >= 5.2.0
Not affected: < 5.2.0
Fixed Versions: 5.2.1.1

Impact

Signed download URLs generated by ActiveStorage for Google Cloud Storage
service and Disk service include content-disposition and content-type
parameters that an attacker can modify. This can be used to upload specially
crafted HTML files and have them served and executed inline. Combined with
other techniques such as cookie bombing and specially crafted AppCache manifests,
an attacker can gain access to private signed URLs within a specific storage path.

Vulnerable apps are those using either GCS or the Disk service in production.
Other storage services such as S3 or Azure aren't affected.

All users running an affected release should either upgrade or use one of the
workarounds immediately. For those using GCS, it's also recommended to run the
following to update existing blobs:

ActiveStorage::Blob.find_each do |blob|
  blob.send :update_service_metadata
end

🚨 We recommend to merge and deploy this update as soon as possible! 🚨

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rails (5.2.1 → 5.2.1.1) · Repo

Commits

See the full diff on Github. The new version differs by 2 commits:

↗️ actioncable (indirect, 5.2.1 → 5.2.1.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 2 commits:

↗️ actionmailer (indirect, 5.2.1 → 5.2.1.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 2 commits:

↗️ actionpack (indirect, 5.2.1 → 5.2.1.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 2 commits:

↗️ actionview (indirect, 5.2.1 → 5.2.1.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 2 commits:

↗️ activejob (indirect, 5.2.1 → 5.2.1.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 2 commits:

↗️ activemodel (indirect, 5.2.1 → 5.2.1.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 2 commits:

↗️ activerecord (indirect, 5.2.1 → 5.2.1.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 2 commits:

↗️ activestorage (indirect, 5.2.1 → 5.2.1.1) · Repo

Sorry, we couldn't find anything useful about this release.

↗️ activesupport (indirect, 5.2.1 → 5.2.1.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 2 commits:

↗️ concurrent-ruby (indirect, 1.0.5 → 1.1.3) · Repo · Changelog

Release Notes

1.1.0

concurrent-ruby:

  • requires at least Ruby 2.0
  • Promises
    are moved from concurrent-ruby-edge to concurrent-ruby
  • Add support for TruffleRuby
    • (#734) Fix Array/Hash/Set construction broken on TruffleRuby
    • AtomicReference fixed
  • fixed documentation and README links
  • fix Set for TruffleRuby and Rubinius
  • CI stabilization
  • remove sharp dependency edge -> core
  • remove warnings
  • documentation updates
  • Exchanger is no longer documented as edge since it was already available in
    concurrent-ruby
  • (#644) Fix Map#each and #each_pair not returning enumerator outside of MRI
  • (#659) Edge promises fail during error handling
  • (#741) Raise on recursive Delay#value call
  • (#727) #717 fix global IO executor on JRuby
  • (#740) Drop support for CRuby 1.9, JRuby 1.7, Rubinius.
  • (#737) Move AtomicMarkableReference out of Edge
  • (#708) Prefer platform specific memory barriers
  • (#735) Fix wrong expected exception in channel spec assertion
  • (#729) Allow executor option in Promise#then
  • (#725) fix timeout check to use timeout_interval
  • (#719) update engine detection
  • (#660) Add specs for Promise#zip/Promise.zip ordering
  • (#654) Promise.zip execution changes
  • (#666) Add thread safe set implementation
  • (#651) #699 #to_s, #inspect should not output negative object IDs.
  • (#685) Avoid RSpec warnings about raise_error
  • (#680) Avoid RSpec monkey patching, persist spec results locally, use RSpec
    v3.7.0
  • (#665) Initialize the monitor for new subarrays on Rubinius
  • (#661) Fix error handling in edge promises

concurrent-ruby-edge:

  • (#659) Edge promises fail during error handling
  • Edge files clearly separated in lib-edge
  • added ReInclude
  • add Promises.zip_futures_over_on
Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ i18n (indirect, 1.1.0 → 1.1.1) · Repo · Changelog

Release Notes

1.1.1

  • Expose translations with an option to perform initialization (if it hasn't been done already) (#353 / #254)
  • Removed un-used Kernel core extension #436
  • Added project metadata for RubyGems #434
Commits

See the full diff on Github. The new version differs by 11 commits:

↗️ loofah (indirect, 2.2.2 → 2.2.3) · Repo · Changelog

Release Notes

2.2.3

Notably, this release addresses CVE-2018-16468.

Commits

See the full diff on Github. The new version differs by 5 commits:

↗️ mail (indirect, 2.7.0 → 2.7.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 20 commits:

↗️ marcel (indirect, 0.3.2 → 0.3.3) · Repo

Release Notes

0.3.3

  • Shush Ruby interpreter warnings (#6)
  • Exclude test files from published gem to shrink it from 7.5 MB to 7.5 KB (#11)
Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ method_source (indirect, 0.9.0 → 0.9.2) · Repo

Commits

See the full diff on Github. The new version differs by 12 commits:

↗️ nokogiri (indirect, 1.8.4 → 1.8.5) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 11 commits:

↗️ rack (indirect, 2.0.5 → 2.0.6) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 5 commits:

↗️ railties (indirect, 5.2.1 → 5.2.1.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 2 commits:

↗️ thor (indirect, 0.20.0 → 0.20.3) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 73 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Nov 28, 2018
@depfu
Copy link
Contributor Author

depfu bot commented Dec 5, 2018

Closed in favor of #15.

@depfu depfu bot closed this Dec 5, 2018
@depfu depfu bot deleted the depfu/update/rails-5.2.1.1 branch December 5, 2018 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

depfu

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants