Skip to content

Conversation

@swagatika60
Copy link
Contributor

This PR reapplies the removal of redundant @slf4j annotations in Azure plugin classes to maintain code consistency and reduce unnecessary dependencies. Previous cleanup required adjustments, which are now fixed.

Details:

Cleaned and verified the following classes:

CreateRun.java

EventHubClientFactory.java

Consume.java

Produce.java

RealtimeTrigger.java

Trigger.java

EventHubConsumerService.java

Ensured no functional logic was modified — only annotation cleanup.

Verified the build locally to confirm no impact on existing functionalities.

Motivation:
Part of ongoing refactoring to simplify logging management across plugins (kestra-io/kestra#12770
).

Checklist:

Removed redundant annotations

Verified successful build

Linked related issue

Linked Issue:
Part of kestra-io/kestra#12770

@kestrabot kestrabot bot added this to Pull Requests Nov 7, 2025
@github-project-automation github-project-automation bot moved this to To review in Pull Requests Nov 7, 2025
@swagatika60
Copy link
Contributor Author

Hi @Malaydewangan09 ,
I’ve made the requested changes — removed all commented @slf4j lines and related imports everywhere.
Could you please review and let me know if anything else is needed before merging?
Thanks for your guidance! 😊

@MilosPaunovic MilosPaunovic added kind/external Pull requests raised by community contributors area/plugin Plugin-related issue or feature request labels Nov 10, 2025
@MilosPaunovic MilosPaunovic requested review from a team and Malaydewangan09 November 10, 2025 07:10
@swagatika60
Copy link
Contributor Author

Hi @Malaydewangan09 ,
I’ve merged the latest changes from main and removed the commented Logger imports as suggested.
The branch is now up-to-date. Please review and approve when you have a moment.

@Malaydewangan09
Copy link
Member

Hey @swagatika60, don't we. have another PR addressing the same issue?
Could you please close any one of them? Thanks!

@MilosPaunovic
Copy link
Member

Hey @swagatika60, are there any updates on this?

@github-project-automation github-project-automation bot moved this from To review to Done in Pull Requests Nov 14, 2025
@github-project-automation github-project-automation bot moved this from Done to To review in Pull Requests Nov 14, 2025
@Malaydewangan09
Copy link
Member

Hey @swagatika60, are there any updates on this?

@swagatika60
Copy link
Contributor Author

Hii @Malaydewangan09 ,
Due to my recent exams, I couldn’t work on the project for some time. Could you please update me on the remaining tasks so I can continue with the work?

@Malaydewangan09
Copy link
Member

CI is failing and also I added some comments to resolve.

@swagatika60
Copy link
Contributor Author

Hey @Malaydewangan09 ,
I have resolved the comments and pushed the changes. Please review.

@swagatika60
Copy link
Contributor Author

Hii @Malaydewangan09 ,
I want to merge my branch changes into the main project. Please review my work.

@swagatika60
Copy link
Contributor Author

Hey @Malaydewangan09 ,
Only these two or any other changes will be require let me know about all the stuffs??

@swagatika60
Copy link
Contributor Author

Hi @Malaydewangan09 ,
I have updated the logging to use runContext.logger() everywhere and removed the unused import in the test file.
Please review and let me know if anything else is required.

@Malaydewangan09
Copy link
Member

@swagatika60, thanks for the contribution, I will take over this and merge it!

@Malaydewangan09 Malaydewangan09 force-pushed the chore/remove-slf4j-azure-v2 branch from 233506a to e183f29 Compare November 19, 2025 16:18
@swagatika60
Copy link
Contributor Author

Hi @Malaydewangan09,

I noticed the branch was force-pushed and the checks are failing. Please let me know if any updates or tasks are needed from my side to get this PR ready for merge.

Thanks!

@Malaydewangan09 Malaydewangan09 merged commit e3217b0 into kestra-io:main Nov 19, 2025
0 of 2 checks passed
@github-project-automation github-project-automation bot moved this from To review to Done in Pull Requests Nov 19, 2025
@swagatika60
Copy link
Contributor Author

Hi @Malaydewangan09,

Thank you so much for reviewing and merging the PR! I’m truly glad for all your support and guidance—it really helped me a lot. Please let me know if there’s anything else I can assist with.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/plugin Plugin-related issue or feature request kind/external Pull requests raised by community contributors

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants