-
Notifications
You must be signed in to change notification settings - Fork 14
Refactor: Reapply @Slf4j cleanup for Azure plugin classes #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Reapply @Slf4j cleanup for Azure plugin classes #215
Conversation
|
Hi @Malaydewangan09 , |
src/main/java/io/kestra/plugin/azure/eventhubs/service/producer/EventHubProducerService.java
Outdated
Show resolved
Hide resolved
src/main/java/io/kestra/plugin/azure/eventhubs/service/producer/ProducerContext.java
Outdated
Show resolved
Hide resolved
|
Hi @Malaydewangan09 , |
|
Hey @swagatika60, don't we. have another PR addressing the same issue? |
|
Hey @swagatika60, are there any updates on this? |
|
Hey @swagatika60, are there any updates on this? |
|
Hii @Malaydewangan09 , |
src/main/java/io/kestra/plugin/azure/eventhubs/service/producer/EventHubProducerService.java
Outdated
Show resolved
Hide resolved
src/main/java/io/kestra/plugin/azure/storage/blob/DeleteList.java
Outdated
Show resolved
Hide resolved
|
CI is failing and also I added some comments to resolve. |
|
Hey @Malaydewangan09 , |
|
Hii @Malaydewangan09 , |
|
Hey @Malaydewangan09 , |
|
Hi @Malaydewangan09 , |
|
@swagatika60, thanks for the contribution, I will take over this and merge it! |
233506a to
e183f29
Compare
|
Hi @Malaydewangan09, I noticed the branch was force-pushed and the checks are failing. Please let me know if any updates or tasks are needed from my side to get this PR ready for merge. Thanks! |
|
Hi @Malaydewangan09, Thank you so much for reviewing and merging the PR! I’m truly glad for all your support and guidance—it really helped me a lot. Please let me know if there’s anything else I can assist with. Thanks again! |
This PR reapplies the removal of redundant @slf4j annotations in Azure plugin classes to maintain code consistency and reduce unnecessary dependencies. Previous cleanup required adjustments, which are now fixed.
Details:
Cleaned and verified the following classes:
CreateRun.java
EventHubClientFactory.java
Consume.java
Produce.java
RealtimeTrigger.java
Trigger.java
EventHubConsumerService.java
Ensured no functional logic was modified — only annotation cleanup.
Verified the build locally to confirm no impact on existing functionalities.
Motivation:
Part of ongoing refactoring to simplify logging management across plugins (kestra-io/kestra#12770
).
Checklist:
Removed redundant annotations
Verified successful build
Linked related issue
Linked Issue:
Part of kestra-io/kestra#12770