Skip to content

Refactor __exit__ method in name_scope context manager to handle thread-local global state #21833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+53 −1
Open

Refactor __exit__ method in name_scope context manager to handle thread-local global state #21833

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99090f6
Refactor __exit__ method in name_scope.py
Abhinavexists Nov 7, 2025
a29619e
Merge branch 'keras-team:master' into patch-1
Abhinavexists Nov 8, 2025
4c4088a
fix
Abhinavexists Nov 8, 2025
85f02ea
remove linting error and added test cases
Abhinavexists Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions keras/src/backend/common/name_scope.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,17 @@ def __enter__(self):
return self

def __exit__(self, *args, **kwargs):
if self._pop_on_exit:
name_scope_stack = global_state.get_global_attribute(
"name_scope_stack"
)
if not self._pop_on_exit():
return
name_scope_stack = global_state.get_global_attribute(
"name_scope_stack"
)
if not name_scope_stack:
return
try:
name_scope_stack.pop()

except (AttributeError, IndexError):
return

def current_path():
name_scope_stack = global_state.get_global_attribute("name_scope_stack")
Expand Down
Loading