Skip to content

Fix flaky test_execution_state test #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krassowski wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix flaky test_execution_state test #1579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
283f3b8
Re-run `test_execution_state` up to three times
krassowski Nov 28, 2025
724a133
Is five times enough?
krassowski Nov 28, 2025
b22c33c
Run only the flaky test on Windows on CI for debugging
krassowski Nov 28, 2025
5b49930
Do not re-run, just wait for startup to fininsh
krassowski Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
run: hatch run test:nowarn || hatch -v run test:nowarn --lf
- name: Run the tests on windows
if: ${{ startsWith(matrix.os, 'windows') }}
run: hatch run cov:nowarn -s || hatch -v run cov:nowarn --lf
run: hatch run cov:nowarn -s -k test_execution_state || hatch -v run cov:nowarn --lf
- uses: jupyterlab/maintainer-tools/.github/actions/upload-coverage@v1

test_docs:
Expand Down
11 changes: 11 additions & 0 deletions tests/services/kernels/test_execution_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,17 @@ async def test_execution_state(jp_fetch, jp_ws_fetch):
)
await poll_for_parent_message_status(kid, message_id, "busy", ws)
es = await get_execution_state(kid, jp_fetch)

# kernels start slowly on Windows
max_startup_time = 60
started = time.time()
while es == "starting":
await asyncio.sleep(1)
elapsed = time.time() - started
if elapsed > max_startup_time:
raise ValueError(f"Kernel did not start up in {max_startup_time} seconds")
es = await get_execution_state(kid, jp_fetch)

assert es == "busy"

message_id_2 = uuid.uuid1().hex
Expand Down
Loading