added mention support in stream_message() #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables persona-to-persona mentions in streaming responses by leveraging the
find_mentionsparameter added toYChat.update_message()in the upstream jupyter-chat library.Changes:
trigger_actions=[]toupdate_message()calls during streaming to defer mention extractionupdate_message(..., trigger_actions=[find_mentions_callback])call after streaming completes to trigger mention extraction and persona notificationsjupyterlab_chat.utilsHow it works:
During streaming: Each chunk calls
update_message(..., append=True, trigger_actions=[])- no callbacks are executed, mentions are NOT extractedWhen complete: Final call to
update_message(..., trigger_actions=[find_mentions_callback])executes the mention extraction callback and notifies mentioned personasThis ensures mentioned personas are only notified once when the complete message is ready, rather than on every incremental update.
Dependencies:
Requires the callback-based trigger_actions parameter in
YChat.update_message()andYChat.add_message()from jupyterlab/jupyter-chat (PR #302).