Added tests to encoded refs to unknown keywords. #683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
These specs pass against my implementation for I am not yet running against
|
Julian
added
the
waiting for author
Contributor
Author
|
Apologies! For some reason I didn't get a notification about this. I'll action it now. |
Member
|
Surely rebasing would fix that? |
jdesrosiers
approved these changes
Oct 29, 2025
Member
jdesrosiers
left a comment
jdesrosiers
left a comment
There was a problem hiding this comment.
This just needed a rebase to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was opened against my json-schema implementation corvus-dotnet/Corvus.JsonSchema#238
This turned out to be an implementation-specific bug that related to the handling of references to non-keyword schema islands.
While this is very much an "implementation specific" issue, it is similar to the existing
refOfUnknownKeywordtests, and catches a case that is not otherwise validated, but is common in e.g. OpenAPI.The Slack discussion is to be found:
https://json-schema.slack.com/archives/C8CQ81GKF/p1690501470341369
This PR adds tests to the existing
optional/refOfUnknownKeyword.jsontests indraft2020-12,draft2019-09anddraft-next.