Skip to content

Conversation

@notunderctrl
Copy link
Contributor

@notunderctrl
Copy link
Contributor Author

Updating for https://github.com/underctrl-io/commandkit

@notunderctrl notunderctrl changed the title change dns from vercel to netlify commandkit.js.org Dec 13, 2024
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, site has content based on https://commandkit.netlify.app/

I trust that your site is configured ready to work with the requested js.org subdomain.

@MattIPv4 MattIPv4 added change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages labels Dec 13, 2024
@indus indus added the 404 The page requested returns a 404 response label Dec 14, 2024
@indus
Copy link
Member

indus commented Dec 14, 2024

I've already added your requested subdomain to JS.ORGs zonefile but get a 404 error. You may have to configure your host to accept the custom domain.
I'll merge after we have "contact". Please keep this PR open.

@notunderctrl
Copy link
Contributor Author

@indus I've configured the host to accept the new js.org domain

@indus indus removed the 404 The page requested returns a 404 response label Dec 15, 2024
@indus
Copy link
Member

indus commented Dec 15, 2024

Welcome back https://commandkit.js.org

@indus indus merged commit f266139 into js-org:master Dec 15, 2024
1 check passed
@notunderctrl notunderctrl deleted the patch branch December 15, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants