Skip to content

xvrtech.js.org #9393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

xvrtech.js.org #9393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PULL_REQUEST_TEMPLATE/addExternalPage.md
View file
Open in desktop
Copy link
Member

@MattIPv4 MattIPv4 Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR should only be editing cnames_active.js

Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
- [x] I have read and accepted the [Terms and Conditions](http://js.org/terms.html)
- [x] There is reasonable content on the page: ***[insert URL here]***
- [x] There is reasonable content on the page: ***[https://github.com/FullStackedRVC/Agency]***
2 changes: 1 addition & 1 deletion PULL_REQUEST_TEMPLATE/addGitHubPage.md
View file
Open in desktop
Copy link
Member

@MattIPv4 MattIPv4 Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR should only be editing cnames_active.js

Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
- [x] I have read and accepted the [Terms and Conditions](http://js.org/terms.html)
- [x] There is reasonable content on the page
- [x] I have added a CNAME file to my repo: ***[insert URL here]***
- [x] I have added a CNAME file to my repo: ***[https://github.com/FullStackedRVC/Agency]***
1 change: 1 addition & 0 deletions cnames_active.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3604,6 +3604,7 @@
"xterminal": "henryhale.github.io/xterminal",
"xto6": "mohebifar.github.io/xto6", // noCF? (don´t add this in a new PR)
"xtype": "lucono.github.io/xtypejs", // noCF? (don´t add this in a new PR)
"xvrtech": "https://fullstackedrvc.github.io/Agency/",

Check failure on line 3607 in cnames_active.js

View workflow job for this annotation

GitHub Actions / validate 

Expected: `  "xvrtech": "fullstackedrvc.github.io/Agency",`
   Found: `  "xvrtech": "https://fullstackedrvc.github.io/Agency/",`
Copy link
Member

@MattIPv4 MattIPv4 Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"xvrtech": "https://fullstackedrvc.github.io/Agency/",
"xvrtech": "fullstackedrvc.github.io/Agency",

You do not need the https:// nor the trailing slash

"y2j": "ultirequiem.github.io/y2j",
"y86": "quietshu.github.io/y86", // noCF? (don´t add this in a new PR)
"yadl": "yadljs.github.io",
Expand Down
Loading