Skip to content

Conversation

@xiangnanscu
Copy link
Contributor

@xiangnanscu xiangnanscu commented Oct 20, 2024

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/xiangnanscu/lua2js/blob/master/src/App.vue

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Oct 20, 2024
@indus indus added the error The page requested returns an error label Oct 20, 2024
@indus
Copy link
Member

indus commented Oct 20, 2024

I've already added your requested subdomain to JS.ORGs zonefile. But you have to fix teh path issues on you page to give me achance to have a look at it before I merge.
Please keep this PR open.

@xiangnanscu
Copy link
Contributor Author

@indus done.

@indus indus removed the error The page requested returns an error label Oct 21, 2024
@indus
Copy link
Member

indus commented Oct 21, 2024

Welcome http://lua2js.js.org

@indus indus merged commit 63e352c into js-org:master Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants