Additional fixes and tweaks for the skinny launcher #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was added to switch JRuby's RubyGems back to using normal shebang lines (rather than env shebangs needed for the shell script) but had the effect of making that JRuby install need a native launcher permanently. Rather than switching off env shebangs, we leave them as is so the native launcher and shell launcher can be interchangeable.
The new skinny launcher depends on jruby.sh being in the same bin dir, but at least one installer (ruby-build) deletes it during initial setup. This patch includes jruby.sh in the gem and copies it into JRuby's bin dir if it does not already exist. See rbenv/ruby-build#2517
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #48 we introduced a new "skinny" launcher for unix platforms that just launches the shipped
bin/jruby.shin JRuby, to ensure it always has the latest launcher logic.Unfortunately, due to issues reported in #48 (comment), we need to check first if the
jruby.shfile exists and either warn or fail to install until the host JRuby install has been fixed.This PR also fixes CI to run properly on the skinny launcher... i.e. not run any of the specs for old launcher's features.