Skip to content

Conversation

@LadySolveig
Copy link
Contributor

Issue # .

Summary of Changes

Adding a clear guidance to the README.md for contributors on which branch to target when submitting pull requests.
The new section uses a simple classification table to help contributors choose the correct branch based on the type of change.

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

Shouldn't the same change also be made in readme.txt?

@LadySolveig
Copy link
Contributor Author

LadySolveig commented Nov 19, 2025

Good question, they are definitely not the same texts, the txt seems to have a few more passages and probably hasn't been updated for a while.

No, sorry, I was wrong, in the 6 branch it is also written on 6 so it is current.

@LadySolveig
Copy link
Contributor Author

LadySolveig commented Nov 19, 2025

The How to get a working installation from the source section is also not in the txt-file.
I don't think it's the idea that they are identical, but I can't say for sure. I think that since it is primarily intended to make collaboration here on Github easier and transparent, the .md file is definitely not wrong.

@chmst
Copy link
Contributor

chmst commented Nov 19, 2025

I have tested this item ✅ successfully on 863fcda

Good Idea.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46471.

@dautrich
Copy link

I have tested this item ✅ successfully on 863fcda

I agree with Christiane.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46471.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46471.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 22, 2025
@richard67 richard67 added this to the Joomla! 5.4.2 milestone Nov 22, 2025
@muhme
Copy link
Contributor

muhme commented Nov 26, 2025

✅ Final check before merging with Codespace – to check the formatting. As discussed, the new section ‘Which branch should my pull request target?’ is not included in ‘readme.txt’ and therefore not in the complete/updated package. It is only visible on GitHub or with git clone. I agree that this is OK, as its primary purpose is to make collaboration on GitHub easier.

@muhme muhme merged commit bfe3c8e into joomla:5.4-dev Nov 26, 2025
60 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 26, 2025
@muhme
Copy link
Contributor

muhme commented Nov 26, 2025

Thank you @LadySolveig for your contribution. Thank you @brianteeman for commenting. Thank you @chmst and @dautrich for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants