-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.4] Docs: Add a PR targeting section to the README #46471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Shouldn't the same change also be made in readme.txt? |
|
Good question, they are definitely not the same texts, the txt seems to have a few more passages and probably hasn't been updated for a while. No, sorry, I was wrong, in the 6 branch it is also written on 6 so it is current. |
|
The |
|
I have tested this item ✅ successfully on 863fcda This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46471. |
|
I have tested this item ✅ successfully on 863fcda This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46471. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46471. |
|
✅ Final check before merging with Codespace – to check the formatting. As discussed, the new section ‘Which branch should my pull request target?’ is not included in ‘readme.txt’ and therefore not in the complete/updated package. It is only visible on GitHub or with git clone. I agree that this is OK, as its primary purpose is to make collaboration on GitHub easier. |
|
Thank you @LadySolveig for your contribution. Thank you @brianteeman for commenting. Thank you @chmst and @dautrich for testing. |
Issue # .
Summary of Changes
Adding a clear guidance to the
README.mdfor contributors on which branch to target when submitting pull requests.The new section uses a simple classification table to help contributors choose the correct branch based on the type of change.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed