Improvement: No database connection required #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merge request will add the ability to use this library with other frameworks, like Spring JDBC. It will also allow its use with PreparedStatements. Additional patches: Using try-with-resources on SQL statements.
jonathanhds
requested changes
Aug 9, 2020
Owner
jonathanhds
left a comment
jonathanhds
left a comment
There was a problem hiding this comment.
Good stuff! Thanks @antonionoca for the changes. Do you mind updating your branch and running mvn prettier:write so we can have all the codebase formatted?
|
@antonionoca @jonathanhds In this if I create a query with parameters then there is no way to get those parameters list and I can only get the query string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request will add the ability to use this library with other frameworks, like Spring JDBC.
It will also allow its use with PreparedStatements.
Additional patches:
Using try-with-resources on SQL statements.