Fixed 'Cannot remove device mapper handle ...' error message. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In luks.c (row 223) the function isLuksMapperAvailable is called with the full path of the device mapper (including /dev/mapper/). In isLuksMapperAvailable a 'cryptsetup status' is performed with that input. However, if you call 'cryptsetup status' with the full path instead of the actual name of the device mapper it will (at least on RHEL 6) return 1 (wrong parameters) as error code, not 4 (wrong device specified). And the user will receive the "Cannot remove device mapper handle ..." error message. The fix is to strip the /dev/mapper part and only run 'cryptsetup status' using the basename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In luks.c (row 223) the function isLuksMapperAvailable is
called with the full path of the device mapper
(including /dev/mapper/). In isLuksMapperAvailable a
'cryptsetup status' is performed with that input.
However, if you call 'cryptsetup status' with the full
path instead of the actual name of the device mapper it
will (at least on RHEL 6) return 1 (wrong parameters) as
error code, not 4 (wrong device specified). And the
user will receive the "Cannot remove device mapper handle
..." error message. The fix is to strip the
/dev/mapper part and only run 'cryptsetup status' using
the basename.