Skip to content

use standalone #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

use standalone #59

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c2a024
use standalone
Jan 9, 2018
294f142
revert
Mar 18, 2018
e794ba4
revert
Mar 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions runtime/chromeDriver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,16 @@
'use strict';

var chromedriver = require('chromedriver');
var selenium = require('selenium-webdriver');

/**
* Creates a Selenium WebDriver using Chrome as the browser
* @returns {ThenableWebDriver} selenium web driver
*/
module.exports = function() {
module.exports = function () {

var driver = new selenium.Builder().withCapabilities({
browserName: 'chrome',
javascriptEnabled: true,
acceptSslCerts: true,
chromeOptions: {
args: ['start-maximized']
},
path: chromedriver.path
}).build();
var driver = new selenium.Builder().
usingServer('http://localhost:4444/wd/hub').
Copy link
Owner

@john-doherty john-doherty Aug 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about users who don't want to run it standalone?

withCapabilities(selenium.Capabilities.chrome()).build();

driver.manage().window().maximize();

Expand Down