Skip to content

Reduce EE 8 compatibility layer #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
basil wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Reduce EE 8 compatibility layer #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 4 additions & 58 deletions src/main/java/org/jenkinsci/plugins/gitserver/HttpGitRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package org.jenkinsci.plugins.gitserver;

import hudson.Util;
import hudson.model.Action;
import io.jenkins.servlet.http.HttpServletRequestWrapper;
import jakarta.servlet.ServletConfig;
import jakarta.servlet.ServletContext;
import jakarta.servlet.ServletException;
Expand Down Expand Up @@ -61,34 +59,8 @@ protected HttpGitRepository() {}
*
* @see ReceivePackFactory#create(Object, Repository)
*/
@SuppressWarnings({"deprecated", "java:S1874"})
public ReceivePack createReceivePack(HttpServletRequest context, Repository db)
throws ServiceNotEnabledException, ServiceNotAuthorizedException {
if (Util.isOverridden(
HttpGitRepository.class,
getClass(),
"createReceivePack",
javax.servlet.http.HttpServletRequest.class,
Repository.class)) {
return createReceivePack(HttpServletRequestWrapper.fromJakartaHttpServletRequest(context), db);
}
throw new AbstractMethodError("Implementing class '" + this.getClass().getName() + "' does not override "
+ "either overload of the createReceivePack method.");
}

/**
* @deprecated Override {@link #createReceivePack(HttpServletRequest, Repository)} instead.
*/
@Deprecated(since = "134")
public ReceivePack createReceivePack(javax.servlet.http.HttpServletRequest context, Repository db)
throws ServiceNotEnabledException, ServiceNotAuthorizedException {
if (Util.isOverridden(
HttpGitRepository.class, getClass(), "createReceivePack", HttpServletRequest.class, Repository.class)) {
return createReceivePack(HttpServletRequestWrapper.toJakartaHttpServletRequest(context), db);
}
throw new AbstractMethodError("Implementing class '" + this.getClass().getName() + "' does not override "
+ "either overload of the createReceivePack method.");
}
public abstract ReceivePack createReceivePack(HttpServletRequest context, Repository db)
throws ServiceNotEnabledException, ServiceNotAuthorizedException;

/**
* Returns the {@link UploadPack} that handles "git fetch" from client.
Expand All @@ -102,34 +74,8 @@ HttpGitRepository.class, getClass(), "createReceivePack", HttpServletRequest.cla
*
* @see UploadPackFactory#create(Object, Repository)
*/
@SuppressWarnings({"deprecated", "java:S1874"})
public UploadPack createUploadPack(HttpServletRequest context, Repository db)
throws ServiceNotEnabledException, ServiceNotAuthorizedException {
if (Util.isOverridden(
HttpGitRepository.class,
getClass(),
"createUploadPack",
javax.servlet.http.HttpServletRequest.class,
Repository.class)) {
return createUploadPack(HttpServletRequestWrapper.fromJakartaHttpServletRequest(context), db);
}
throw new AbstractMethodError("Implementing class '" + this.getClass().getName() + "' does not override "
+ "either overload of the createUploadPack method.");
}

/**
* @deprecated Override {@link #createUploadPack(HttpServletRequest, Repository)} instead.
*/
@Deprecated(since = "134")
public UploadPack createUploadPack(javax.servlet.http.HttpServletRequest context, Repository db)
throws ServiceNotEnabledException, ServiceNotAuthorizedException {
if (Util.isOverridden(
HttpGitRepository.class, getClass(), "createUploadPack", HttpServletRequest.class, Repository.class)) {
return createUploadPack(HttpServletRequestWrapper.toJakartaHttpServletRequest(context), db);
}
throw new AbstractMethodError("Implementing class '" + this.getClass().getName() + "' does not override "
+ "either overload of the createUploadPack method.");
}
public abstract UploadPack createUploadPack(HttpServletRequest context, Repository db)
throws ServiceNotEnabledException, ServiceNotAuthorizedException;

/**
* to make sure the user has the permission to pull.
Expand Down