Remove redundant curl_close in PlexApi.php #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unnecessary curl_close call before returning response. PHP 8.5 deprecated curl_close() See: https://www.php.net/manual/en/function.curl-close.php https://www.php.net/manual/en/migration85.deprecated.php
There was a problem hiding this comment.
Pull request overview
This PR prepares the codebase for PHP 8.5 compatibility by removing an explicit curl_close() call, which has been deprecated in PHP 8.5. The change relies on PHP's automatic resource cleanup when the curl resource goes out of scope, which is the recommended approach going forward.
- Removes explicit
curl_close()call before returning the response in thecallmethod - Aligns with PHP 8.5 deprecation of
curl_close()function - Maintains existing functionality through PHP's automatic resource management
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessary curl_close call before returning response.
PHP 8.5 deprecated curl_close()
See:
https://www.php.net/manual/en/function.curl-close.php
https://www.php.net/manual/en/migration85.deprecated.php