Use params for remove method

[mdartic]

Actually, only the key is used in the remove method.
But we could specify other options, like the Bucket where the object is store.

This PR will use the params property if it exist in the opts parameter of the remove method, like it's already done in others method of the blob store.

What do you think about it ?

[claustres]

It seems to me a great addition insuring create/remove methods are similar. A default bucket can be specified so that you can omit it in params or specify it if required.

[claustres]

There is a console.log() to be removed though.

[mdartic]

Indeed, thanks :-)

[jb55]

this would almost always crash because params would likely be undefined.

opts = { key: "somekey" }
var params = typeof opts === 'object' ? opts.params : {}

params would be undefined at this point

params.Bucket = undefined.Bucket <-- boom

[mdartic]

Oops... sorry, you're absolutely right.

What do you think of this code :

  var params = {}
  if (typeof opts === 'string') {
    params.Key = opts;
  } else {
    opts = Object.assign({}, opts, {
      params: Object.assign({}, opts.params)
    });
    params.Key = opts.key;
    params.Bucket = opts.params.Bucket || this.bucket;
  }
  this.s3.deleteObject(params, done);
  return this;

[jb55]

I think this should be backwards compatible? then you could just pass the whole params object as opts instead of having a params subkey?

let params = Object.assign({}, opts)
params.Key = params.Key || params.key
params.Bucket = params.Bucket || this.bucket
delete params.key

[jb55]

actually the main issue is I'm not sure if s3.deleteObject gets mad if there are extra params, because there is probably code out there that passes something other than key in opts. I should test this...

[jb55]

nm I'm dumb it's been so long since I used blob-store and I remember now that params have a standard interface so my suggestion doesn't make sense. I think params in opts is fine, will update soon.

[jb55]

I just remembered we already have code to do this, I've refactored uploadParams into baseParams and did a PR here with the change: #27

[mdartic]

I review your PR, and if it's merged, I think my PR will be useless :-)