Fix table background in dark mode #278
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think the intended effect is an improvement over the current arrangement which I believe was brought into place in #240. When I tested the changes in d522cdf locally, I got the sense that they don't work for older versions of the docs though, e.g. http://localhost:8000/1.36.0/docs/peg.html:
Perhaps it is the case that #240 also didn't account for older versions? @oliverfencott How does it look to you? |
Contributor
Looks good to me! You're correct that dark mode doesn't work for older versions. I've started a branch that will fix this, though; I'll open a PR later this week for it. |
Merged
Contributor
Author
|
See #279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After