Make examples file naming friendlier to Windows #247
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yup, this looks fine to me. Since this is a Makefile based project I don't really use windows for this but that could be revisited. |
Collaborator
Author
|
Re: operation on Windows As a data point, I tried The result was that mongoose wouldn't build (presumably this is for circlet). If I can figure out how to set up a [1] I think this was set up via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address #244.
Please see that issue for some background.
If this PR is merged before #242, one of the files in that PR should probably have its filename changed.
The file in question is this one. It is currently named
->.janet, but likely a better name might end up being-_62.janet.