Skip to content

Optimize write artifacts to disk in watch mode #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Nov 27, 2025
Merged

Optimize write artifacts to disk in watch mode #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
b580de7
Artifact lookup cache
Nov 23, 2025
8ef67c4
Generate and write to disk artifacts lookup hash
Nov 23, 2025
89cafc5
Rename artifact look cache to file system state
Nov 24, 2025
265c0a1
Remove the persisted file system state
Nov 24, 2025
92f455c
Write only changed files to disk in watch mode
Nov 24, 2025
bc1a23e
Remove serialization trait
Nov 24, 2025
6d4efc2
Remove unused imports
Nov 24, 2025
18406a5
Rename commited_artifacts to artifacts_to_write
Nov 24, 2025
9b65459
Merge branch 'main' into lm/create-artifacts-hash
Nov 24, 2025
0d10bff
fix from merge conflict
Nov 24, 2025
58eea9a
Add tracing to get_artifacts_to_write
Nov 25, 2025
3e1a5b6
Merge branch 'main' into lm/create-artifacts-hash
Nov 25, 2025
58ab26b
fix merge conflict
Nov 25, 2025
7bfef33
Replace ChangedFactory with a vector a FileSystemOperation
Nov 25, 2025
cb7151b
Merge branch 'main' into lm/create-artifacts-hash
Nov 25, 2025
cf8a101
tracing->skip_all
Nov 25, 2025
a8ba635
FileSystemState unit tests
Nov 25, 2025
04506a2
Merge branch 'main' into lm/create-artifacts-hash
Nov 26, 2025
f9053f5
refactor mutable state to pure functions
Nov 26, 2025
9322fa4
fix loop position
Nov 26, 2025
29fb325
reduce redundant CreateDirectory operations
Nov 26, 2025
4499ae3
Use FileContent index insteaf of cloning it
Nov 26, 2025
b7e5b3f
remove references to &Copy
Nov 26, 2025
7388fce
turn diff a pure function
Nov 26, 2025
5451d26
rewrite tests
Nov 26, 2025
e578ec0
fmt
Nov 26, 2025
e9dc514
rename unused arg
Nov 26, 2025
bf2297d
Remove unecessary delete operations
Nov 26, 2025
ab17a25
nits: remove type annotations and unnecessary variable declarations
Nov 26, 2025
979e70d
improve variable names in diff
Nov 26, 2025
d9ed1a6
a few more variable name improvements
Nov 26, 2025
75a8e99
some nit improvs
Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/artifact_content/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ graphql_lang_types = { path = "../graphql_lang_types" }
intern = { path = "../../relay-crates/intern" }
isograph_schema = { path = "../isograph_schema" }
isograph_config = { path = "../isograph_config" }
pico = { path = "../pico" }
isograph_lang_types = { path = "../isograph_lang_types" }
prelude = { path = "../prelude" }
indexmap = { workspace = true }
Expand Down
Loading
Loading