add close event for wx timer app in loop_wx #1478
Merged
+24
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
approved these changes
Nov 26, 2025
Collaborator
ianthomas23
left a comment
ianthomas23
left a comment
There was a problem hiding this comment.
Thanks @newville, it looks good to me. I'll defer to your wx knowledge that this is fine from a wx point of view.
Linting failure is unrelated so I will fix that separately.
Contributor
Author
|
@ianthomas23 Thanks for the very quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1477 by adding a "close event" to the wxPython timer app.
The
wxclose event callswakeone final time, and cleanly stops the Timer, and destroys the wx Frame.