Fix ipv6 notations and add tests #90
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the
DefaultCacheclass to handle IPv6 addresses with various notations, adds new methods for IP normalization, and significantly expands test coverage to ensure correctness. The changes focus on improving cache key handling, ensuring consistent behavior for IP addresses with different notations, and extending test cases for both IPv4 and IPv6 scenarios. Supersedes and closes #78 and fixes #70 .Enhancements to
DefaultCache:getmethod to normalize and return IPv6 addresses in the same notation as the input, ensuring consistency between user input and cached data.getIpAddressmethod to extract and normalize IP addresses from cache keys.sanitizeNamemethod to normalize IPv6 addresses by converting them into a standard notation and replacing forbidden characters in cache keys.Expanded Test Coverage:
New Test Cases for IPv6 Handling:
Updated Test Data:
testLookupandtestGetBatchDetailsto reflect updated data received from the API.Tests For Users With Free Token: