fix(player): Resolve race condition on initialization #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of the `InteractiveVideo` component was susceptible to a race condition where the `IVLabsPlayer` could be initialized before the container element was available in the DOM. This would cause the player to fail to load. This commit resolves the issue by wrapping the player initialization in a `setTimeout` with a delay of 0. This ensures that the player is only initialized after the current event loop has completed and the container element is available. Additionally, this commit: - Adds the `@vitejs/plugin-react` dependency to support React in Vite. - Updates the Vitest configuration to include the React plugin. - Refactors the event listener registration to be more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of the
InteractiveVideocomponent was susceptible to a race condition where theIVLabsPlayercould be initialized before the container element was available in the DOM. This would cause the player to fail to load.This commit resolves the issue by wrapping the player initialization in a
setTimeoutwith a delay of 0. This ensures that the player is only initialized after the current event loop has completed and the container element is available.Additionally, this commit:
@vitejs/plugin-reactdependency to support React in Vite.