feature: multi-gpu madvise #864
Draft
+113
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Do not Merge! |
Implements madvise SVM allocated memory for multi-gpu Signed-off-by: Chandio, Bibrak Qamar <bibrak.qamar.chandio@intel.com>
bibrak
force-pushed
the
multi-gpu-madvise
branch
from
917fc00 to
1fe058f
Compare
Implements madvise SVM allocated memory for multi-gpu Signed-off-by: Chandio, Bibrak Qamar <bibrak.qamar.chandio@intel.com>
MichalMrozek
reviewed
Nov 7, 2025
| // Apply the shared system USM IOCTL to all the VMs of the device | ||
| std::vector<uint32_t> vmIds; | ||
| vmIds.reserve(subDeviceIds.size()); | ||
| for (auto subDeviceId : subDeviceIds) { |
Contributor
There was a problem hiding this comment.
this would be error prone that we pass targetDeviceDrm and subdevices seperatly, can you pass targetDevice and wihin this function extract sub device ids , this way the potential mismatch would be not possible
Implements madvise SVM allocated memory for multi-gpu Signed-off-by: Chandio, Bibrak Qamar <bibrak.qamar.chandio@intel.com> Signed-off-by: Falkowski, John <john.falkowski@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled multi-gpu madvise for SVM (System Shared Memory) allocated memory.