Skip to content

Commit dda4beb

Browse files
Revert "performance: enable Direct Submission on LNL Linux"
This reverts commit b7d21b1. Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
1 parent 9d24958 commit dda4beb

File tree

5 files changed

+14
-10
lines changed

5 files changed

+14
-10
lines changed

shared/source/xe2_hpg_core/lnl/os_agnostic_product_helper_lnl.inl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,6 @@ std::optional<GfxMemoryAllocationMethod> ProductHelperHw<gfxProduct>::getPreferr
3535
return GfxMemoryAllocationMethod::allocateByKmd;
3636
}
3737

38-
template <>
39-
bool ProductHelperHw<gfxProduct>::isDirectSubmissionSupported(ReleaseHelper *releaseHelper) const {
40-
return true;
41-
}
42-
4338
template <>
4439
bool ProductHelperHw<gfxProduct>::blitEnqueuePreferred(bool isWriteToImageFromBuffer) const {
4540
return isWriteToImageFromBuffer;

shared/source/xe2_hpg_core/windows/product_helper_lnl.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,11 @@ uint64_t ProductHelperHw<gfxProduct>::overridePatIndex(bool isUncachedType, uint
4747
return patIndex;
4848
}
4949

50+
template <>
51+
bool ProductHelperHw<gfxProduct>::isDirectSubmissionSupported(ReleaseHelper *releaseHelper) const {
52+
return true;
53+
}
54+
5055
template <>
5156
bool ProductHelperHw<gfxProduct>::restartDirectSubmissionForHostptrFree() const {
5257
return true;

shared/test/unit_test/xe2_hpg_core/lnl/linux/product_helper_tests_lnl_linux.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,10 @@ LNLTEST_F(LnlProductHelperLinux, givenProductHelperWhenAskedIsKmdMigrationSuppor
6060
EXPECT_FALSE(productHelper->isKmdMigrationSupported());
6161
}
6262

63+
LNLTEST_F(LnlProductHelperLinux, givenProductHelperWhenCheckDirectSubmissionSupportedThenFalseIsReturned) {
64+
EXPECT_FALSE(productHelper->isDirectSubmissionSupported(releaseHelper));
65+
}
66+
6367
LNLTEST_F(LnlProductHelperLinux, givenProductHelperWhenCheckIsCopyBufferRectSplitSupportedThenReturnsTrue) {
6468
EXPECT_TRUE(productHelper->isCopyBufferRectSplitSupported());
6569
}

shared/test/unit_test/xe2_hpg_core/lnl/product_helper_tests_lnl.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,3 @@ LNLTEST_F(LnlProductHelper, givenProductHelperWhenCheckingIsDeviceUsmAllocationR
157157
LNLTEST_F(LnlProductHelper, givenProductHelperWhenCheckingIsBufferPoolAllocatorSupportedThenCorrectValueIsReturned) {
158158
EXPECT_TRUE(productHelper->isBufferPoolAllocatorSupported());
159159
}
160-
161-
LNLTEST_F(LnlProductHelper, givenProductHelperWhenCheckDirectSubmissionSupportedThenTrueIsReturned) {
162-
EXPECT_TRUE(productHelper->isDirectSubmissionSupported(releaseHelper));
163-
}

shared/test/unit_test/xe2_hpg_core/lnl/windows/product_helper_tests_lnl_windows.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ using namespace NEO;
1919

2020
using LnlProductHelperWindows = ProductHelperTest;
2121

22+
LNLTEST_F(LnlProductHelperWindows, givenProductHelperWhenCheckDirectSubmissionSupportedThenTrueIsReturned) {
23+
EXPECT_TRUE(productHelper->isDirectSubmissionSupported(releaseHelper));
24+
}
25+
2226
LNLTEST_F(LnlProductHelperWindows, givenProductHelperWhenDcFlushMitigationThenReturnFalse) {
2327
EXPECT_FALSE(productHelper->mitigateDcFlush());
2428
EXPECT_FALSE(productHelper->isDcFlushMitigated());
@@ -72,4 +76,4 @@ LNLTEST_F(LnlProductHelperWindows, givenProductHelperWhenOverridePatIndexCalledT
7276

7377
LNLTEST_F(LnlProductHelperWindows, givenProductHelperWhenCheckIsCopyBufferRectSplitSupportedThenReturnsTrue) {
7478
EXPECT_TRUE(productHelper->isCopyBufferRectSplitSupported());
75-
}
79+
}

0 commit comments

Comments
 (0)