Skip to content

Commit 9d24958

Browse files
Revert "feature: add global driver dispatch as prework for DDI handles extens...
This reverts commit dce4ca8. Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
1 parent 85b0d1f commit 9d24958

File tree

13 files changed

+505
-1136
lines changed

13 files changed

+505
-1136
lines changed

level_zero/CMakeLists.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ if(BUILD_WITH_L0)
208208
endif()
209209
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/core/source/cmdlist${BRANCH_DIR_SUFFIX})
210210
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/core/source/cmdlist/cmdlist_extended${BRANCH_DIR_SUFFIX})
211+
include_directories(ddi)
211212

212213
# Create our shared library/DLL
213214
configure_file(ze_intel_gpu_version.h.in ${NEO_BUILD_DIR}/ze_intel_gpu_version.h)
@@ -342,7 +343,6 @@ if(BUILD_WITH_L0)
342343
hide_subdir(api)
343344
add_subdirectory_unique(source)
344345

345-
hide_subdir(ddi)
346346
hide_subdir(experimental)
347347
hide_subdir(include)
348348
set(L0_RELEASE_LIB_NAME "${TARGET_NAME_L0}_lib")
@@ -360,7 +360,6 @@ if(BUILD_WITH_L0)
360360
${CMAKE_CURRENT_SOURCE_DIR}/CMakeLists.txt
361361
)
362362
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/api "${NEO_BUILD_DIR}/${LIB_NAME}/api")
363-
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/ddi "${NEO_BUILD_DIR}/${LIB_NAME}/ddi")
364363
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/core/source "${NEO_BUILD_DIR}/${LIB_NAME}/core/source")
365364
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/experimental "${NEO_BUILD_DIR}/${LIB_NAME}/experimental")
366365
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/include "${NEO_BUILD_DIR}/${LIB_NAME}/include")

level_zero/api/core/ze_core_loader.cpp

Lines changed: 221 additions & 215 deletions
Large diffs are not rendered by default.

level_zero/api/sysman/ze_sysman_loader.cpp

Lines changed: 182 additions & 174 deletions
Large diffs are not rendered by default.

level_zero/api/tools/ze_tools_loader.cpp

Lines changed: 85 additions & 79 deletions
Large diffs are not rendered by default.

level_zero/core/source/global_teardown.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
#include "level_zero/core/source/driver/driver.h"
1313
#include "level_zero/core/source/driver/driver_handle_imp.h"
14-
#include "level_zero/ddi/ze_ddi_tables.h"
1514
#include "level_zero/sysman/source/driver/sysman_driver_handle_imp.h"
1615

1716
namespace L0 {
@@ -20,9 +19,6 @@ decltype(&zelLoaderTranslateHandle) loaderTranslateHandleFunc = nullptr;
2019
decltype(&zelSetDriverTeardown) setDriverTeardownFunc = nullptr;
2120

2221
void globalDriverSetup() {
23-
globalDriverDispatch.core.isValidFlag = true;
24-
globalDriverDispatch.tools.isValidFlag = true;
25-
globalDriverDispatch.sysman.isValidFlag = true;
2622
if (!globalDriverHandles) {
2723
globalDriverHandles = new std::vector<_ze_driver_handle_t *>;
2824
}
@@ -68,8 +64,5 @@ void globalDriverTeardown() {
6864
delete Sysman::globalSysmanDriver;
6965
Sysman::globalSysmanDriver = nullptr;
7066
}
71-
globalDriverDispatch.core.isValidFlag = false;
72-
globalDriverDispatch.tools.isValidFlag = false;
73-
globalDriverDispatch.sysman.isValidFlag = false;
7467
}
7568
} // namespace L0

level_zero/core/test/common/ult_config_listener_l0.cpp

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,16 @@
99

1010
#include "level_zero/core/source/driver/driver.h"
1111
#include "level_zero/core/source/driver/driver_handle_imp.h"
12-
#include "level_zero/ddi/ze_ddi_tables.h"
1312
#include "level_zero/sysman/source/driver/sysman_driver_handle_imp.h"
1413

1514
void L0::UltConfigListenerL0::OnTestStart(const ::testing::TestInfo &testInfo) {
1615
BaseUltConfigListener::OnTestStart(testInfo);
17-
globalDriverDispatch.core.isValidFlag = true;
18-
globalDriverDispatch.tools.isValidFlag = true;
19-
globalDriverDispatch.sysman.isValidFlag = true;
16+
2017
globalDriverHandles->clear();
2118
}
2219

2320
void L0::UltConfigListenerL0::OnTestEnd(const ::testing::TestInfo &testInfo) {
24-
globalDriverDispatch.core.isValidFlag = false;
25-
globalDriverDispatch.tools.isValidFlag = false;
26-
globalDriverDispatch.sysman.isValidFlag = false;
21+
2722
EXPECT_TRUE(globalDriverHandles->empty());
2823
EXPECT_EQ(nullptr, L0::Sysman::globalSysmanDriver);
2924

level_zero/core/test/unit_tests/os_interface/global_teardown_tests.cpp

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
#include "level_zero/core/source/driver/driver_handle_imp.h"
1717
#include "level_zero/core/source/driver/driver_imp.h"
1818
#include "level_zero/core/source/global_teardown.h"
19-
#include "level_zero/ddi/ze_ddi_tables.h"
2019
#include "level_zero/sysman/source/driver/sysman_driver_handle_imp.h"
2120

2221
namespace L0 {
@@ -192,24 +191,5 @@ TEST_F(GlobalTearDownTests, givenForkedProcessWhenGlobalTearDownFunctionCalledTh
192191
delete tempDriver;
193192
}
194193

195-
TEST_F(GlobalTearDownTests, givenGlobalDriverDispatchWhenGlobalSetupAndTeardownAreCalledThenPerApiValidFlagsAreChanged) {
196-
VariableBackup<DriverDispatch> globalDispatchBackup{&globalDriverDispatch};
197-
198-
globalDriverDispatch.core.isValidFlag = false;
199-
globalDriverDispatch.tools.isValidFlag = false;
200-
globalDriverDispatch.sysman.isValidFlag = false;
201-
202-
globalDriverSetup();
203-
204-
EXPECT_TRUE(globalDriverDispatch.core.isValidFlag);
205-
EXPECT_TRUE(globalDriverDispatch.tools.isValidFlag);
206-
EXPECT_TRUE(globalDriverDispatch.sysman.isValidFlag);
207-
208-
globalDriverTeardown();
209-
210-
EXPECT_FALSE(globalDriverDispatch.core.isValidFlag);
211-
EXPECT_FALSE(globalDriverDispatch.tools.isValidFlag);
212-
EXPECT_FALSE(globalDriverDispatch.sysman.isValidFlag);
213-
}
214194
} // namespace ult
215195
} // namespace L0

level_zero/core/test/unit_tests/sources/loader/test_loader.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,10 @@
77

88
#include "shared/test/common/test_macros/test.h"
99

10-
#include "level_zero/ddi/ze_ddi_tables.h"
1110
#include <level_zero/ze_api.h>
1211

12+
#include "ze_ddi_tables.h"
13+
1314
namespace L0 {
1415
namespace ult {
1516

level_zero/ddi/CMakeLists.txt

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)