Skip to content

Stm error handling with anyhow #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Stm error handling with anyhow #2765

wants to merge 4 commits into from

Conversation

@curiecrypt
Copy link
Collaborator

@curiecrypt curiecrypt commented Nov 5, 2025 •
edited
Loading

Content

This PR includes the changes needed to adapt the error handling of mithril-stm to the best practices described here.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • No new TODOs introduced

Comments

Issue(s)

Relates to #2764

@github-actions
Copy link

github-actions bot commented Nov 5, 2025 •
edited
Loading

Test Results

    4 files  ±0    168 suites  ±0   23m 7s ⏱️ -6s
2 210 tests ±0  2 210 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 895 runs  ±0  6 895 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8fc91b8. ± Comparison against base commit 57e1490.

♻️ This comment has been updated with latest results.

@curiecrypt curiecrypt marked this pull request as ready for review November 17, 2025 09:04
@curiecrypt curiecrypt requested a review from jpraynaud November 17, 2025 09:05
jpraynaud
jpraynaud reviewed Nov 17, 2025
View reviewed changes
@curiecrypt curiecrypt force-pushed the curiecrypt/refactor-stm-error-handling branch from 90bf14e to e4d51b8 Compare November 19, 2025 11:57
@curiecrypt curiecrypt force-pushed the curiecrypt/refactor-stm-error-handling branch from e4d51b8 to 9a6ba00 Compare November 19, 2025 13:57
@curiecrypt curiecrypt requested a review from jpraynaud November 19, 2025 14:03
jpraynaud
jpraynaud reviewed Nov 19, 2025
View reviewed changes
jpraynaud
jpraynaud reviewed Nov 19, 2025
View reviewed changes
jpraynaud
jpraynaud approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@curiecrypt @jpraynaud
change log and crates version
a22a5c5 
Co-authored-by: Jean-Philippe Raynaud <jp.raynaud@gmail.com>
@curiecrypt curiecrypt force-pushed the curiecrypt/refactor-stm-error-handling branch from 140228e to a22a5c5 Compare November 19, 2025 16:30
@curiecrypt curiecrypt requested a review from jpraynaud November 19, 2025 17:15
@curiecrypt curiecrypt deployed to testing-preview November 19, 2025 17:24 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpraynaud jpraynaud Awaiting requested review from jpraynaud

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@curiecrypt @jpraynaud