Skip to content

Conversation

@ylenianistico
Copy link

No description provided.

@ylenianistico ylenianistico requested review from Copilot and giulioturrisi and removed request for Copilot November 24, 2025 14:49
Copilot finished reviewing on behalf of ylenianistico November 24, 2025 14:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the ROS2 interface package from dls2_interfaces (plural) to dls2_interface (singular) for consistency. The change affects the package definition, all module declarations in IDL files, and import statements in Python files that use these ROS2 messages.

  • Updated package name in ROS2 package configuration files (package.xml, CMakeLists.txt)
  • Changed module namespace from dls2_interfaces to dls2_interface in all IDL files
  • Updated Python imports in controller and simulator scripts to use the new package name
  • Added new message definition files (.msg) and IDL files with the corrected namespace

Reviewed changes

Copilot reviewed 10 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
deploy/run_simulator_ros2.py Updated import statement to use dls2_interface instead of dls2_interfaces
deploy/run_controller_ros2.py Updated import statement to use dls2_interface instead of dls2_interfaces
deploy/ros2_ws/src/dls2_interface/package.xml Changed package name from dls2_interfaces to dls2_interface
deploy/ros2_ws/src/dls2_interface/CMakeLists.txt Updated project name from dls2_interfaces to dls2_interface
deploy/ros2_ws/src/dls2_interface/msg/*.msg Added ROS2 message definition files (BaseState, BlindState, FeetContactState, Imu, Pose, Screw, TrajectoryGenerator)
deploy/ros2_ws/src/dls2_interface/idl/*.idl Updated module namespace from dls2_interfaces to dls2_interface in all IDL files and added DlsAnnotation.idl
deploy/ros2_ws/src/dls2_interface/LICENSE Added Apache 2.0 license file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant