created public interface EvcsModel based on EvModel as reference #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nterface EvcsModel based on EvModel as reference
Resolves #421 changelog
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Thanks for adapting this. Just two minor things.
|
|
||
| ### Added | ||
| - Enhanced `ExtEmDataConnection` with `simulateInternal` method [#398](https://github.com/ie3-institute/simonaAPI/issues/398) | ||
| - created public interface EvcsModel based on EvModel as reference [#421](https://github.com/ie3-institute/simonaAPI/issues/421) |
Member
There was a problem hiding this comment.
Suggested change
| - created public interface EvcsModel based on EvModel as reference [#421](https://github.com/ie3-institute/simonaAPI/issues/421) | |
| - created public interface EvcsModel [#421](https://github.com/ie3-institute/simonaAPI/issues/421) |
| * @return the maximum DC apparent or active power rating of this evcs | ||
| */ | ||
| ComparableQuantity<Power> getPRatedDC(); | ||
|
|
Member
There was a problem hiding this comment.
Since the Evcs only has sRated, the entry for getPRatedDC can be removed. Also please change the naming of getSRatedAC to getSRated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #421 Provide getter for 'Evcs.cosPhiRated()'created public interface EvcsModel based on EvModel as reference