-
Notifications
You must be signed in to change notification settings - Fork 0
Added API structure to the docs #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
danielfeismann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the docs. Some comments from my side
| There is currently only one interface that is not part of a category. This is the [ExtLinkInterface](/extlinkinterface) | ||
| that is used for loading external simulations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats the reason this is uncategorized while externalSimulation is part of Simulation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The external link interface is not part of any sub-directories. Since the interface is used to link the external simulation to SIMONA is doesn't fit into the simulation sub-directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, may it is an own category? I would like to avoid uncategorized. Or do you have good idea on that?
| ## Simulation | ||
|
|
||
| The simulation package contains the available simulations. Currently, only base classes that needs to be implemented are | ||
| provided. The most important class is the [ExtSimulation](/simulations/externalsimulation) as it is the base class for | ||
| all external simulations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me this becomes not really clear. What is mend by saying, it contains the available simulations. How is this group different from e.g. data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data contains the models and connections that can be used for an external simulation. If someone want to create an external simulation, a subclass of ExtSimulation is needed.
In the sub-directory simulation are currently two external simulation classes available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can enhance this a bit to get this understandable for other users that aren't that deep into this?
| ## Data | ||
|
|
||
| The data package and its sub-packages contains all data-related classes. These are among other things [data connections](/connections/connections), | ||
| data containers and models. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be linked with `Data Connections``?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data connections is a seperat site. I linked to it, since this site is only mend to explain the API structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, but link is broken since the myst crossref is not set properly
Resolves #405