Skip to content

Conversation

@staudtMarius
Copy link
Member

Resolves #405

@staudtMarius staudtMarius added this to the 0.13.0 milestone Nov 28, 2025
@staudtMarius staudtMarius self-assigned this Nov 28, 2025
@staudtMarius staudtMarius added the documentation Improvements or additions to documentation label Nov 28, 2025
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs. Some comments from my side

Comment on lines +44 to +45
There is currently only one interface that is not part of a category. This is the [ExtLinkInterface](/extlinkinterface)
that is used for loading external simulations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the reason this is uncategorized while externalSimulation is part of Simulation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The external link interface is not part of any sub-directories. Since the interface is used to link the external simulation to SIMONA is doesn't fit into the simulation sub-directory.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, may it is an own category? I would like to avoid uncategorized. Or do you have good idea on that?

Comment on lines +35 to +39
## Simulation

The simulation package contains the available simulations. Currently, only base classes that needs to be implemented are
provided. The most important class is the [ExtSimulation](/simulations/externalsimulation) as it is the base class for
all external simulations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this becomes not really clear. What is mend by saying, it contains the available simulations. How is this group different from e.g. data?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data contains the models and connections that can be used for an external simulation. If someone want to create an external simulation, a subclass of ExtSimulation is needed.

In the sub-directory simulation are currently two external simulation classes available.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can enhance this a bit to get this understandable for other users that aren't that deep into this?

Comment on lines +13 to +16
## Data

The data package and its sub-packages contains all data-related classes. These are among other things [data connections](/connections/connections),
data containers and models.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be linked with `Data Connections``?

Copy link
Member Author

@staudtMarius staudtMarius Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data connections is a seperat site. I linked to it, since this site is only mend to explain the API structure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, but link is broken since the myst crossref is not set properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding API structure to docs

3 participants