Sorting: Let's move new pulls to the top #427
Conversation
Previously, with older pulls on top, newer pulls would get less attention until *they too* were old. Yes, there are likely some process changes so that we have less old pulls sitting around. But at the moment, it's rather unhelpful to have most new things be relegated to the end of the list.
| // Older pulls before younger pulls | ||
| a.created_at.localeCompare(b.created_at) | ||
| // younger pulls before older pulls | ||
| b.created_at.localeCompare(a.created_at) |
There was a problem hiding this comment.
Should we do updated_at instead? i.e. if someone is doing a good job updating the code? I know that timestamp may count for things like comments right now
There was a problem hiding this comment.
Should we do updated_at instead?
That would be the updated_at of the pull request itself (which I think is just bumped when a pull description or title is updated).
It's a good point though. We might be able to get a more change-aware date (most recent comment or something).
Not 100% sure we want that (sort order changing frequently), but I'm open to it.
There was a problem hiding this comment.
The most sane sorting I can think of, related to updates, is the date of the last commit.
I'm not sure I'd want new comments to sort to the top, just new code.
masonmcelvain
left a comment
masonmcelvain
left a comment
There was a problem hiding this comment.
CR 👏🏻 I like the idea of newer work at the top and older work at the bottom
I think created_at and updated_at are both reasonable, I'm indifferent
|
I like created_at first so the ordering is consistent. That said.. a future option could put that in a sorting option pretty easily. QA 👍 It works as expected. |
Previously, with older pulls on top, newer pulls would get less attention until they too were old.
Yes, there are likely some process changes so that we have less old pulls sitting around. But at the moment, it's rather unhelpful to have most new things be relegated to the end of the list.