Participants: Add a UI component #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out, this was generating pull-card-demo.html which isn't' what's used when accessing /pull-card-demo (that is dynamically generated using webpack? and doesn't include the body classes we added for chakra). Now /pull-card-demo should load the generated index.html and thus have the same look and feel as the main page.
This indicates how many unique participants have left a comment or review. This also allows the "personal view" filter to include pulls you've commented on. Note: participants doesn't include the Author because I found myself having to explicitly exclude the Author every time I was checking for participants.
danielbeardsley
force-pushed
the
commented-on
branch
from
efdca78 to
27cbb50
Compare
Member
Author
|
QA 👍 Seems like it works on pulldasher-dev!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This indicates how many unique participants have left a comment or review.
This also allows the "personal view" filter to include pulls you've
commented on.
Note: participants doesn't include the Author because I found myself
having to explicitly exclude the Author every time I was checking for
participants.