Initial addition of BitTorrent protocol #59
Conversation
jackyzha0
left a comment
jackyzha0
left a comment
There was a problem hiding this comment.
generally looks good! a few questions/nits
|
https://0xacab.org/sutty/distributed-press-api-client/-/issues/12 Tracking the client side |
jackyzha0
left a comment
jackyzha0
left a comment
There was a problem hiding this comment.
lgtm! small non-blocking question
| async unsync (id: string, _site: Static<typeof BitTorrentProtocolFields>, ctx?: Ctx): Promise<void> { | ||
| } |
There was a problem hiding this comment.
Is there nothing for unsync?
There was a problem hiding this comment.
Whoops, not yet. It's a TODO.
|
Also, a question. What should we do about existing sites that don't have the protocol set already? I was thinking in the sites.get() function we could check for missing properties and add them in. cc @jackyzha0 thoughts? |
|
Might be good to start thinking about migration scripts? Ideally a one-time thing instead of something that runs on every |
|
great stuff |
Before I get way further it'd be nice if I could get a vibe check on what we have so far and answer any questions about it.