Release 0.8.36b1: Agents Support in SDK #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibratu
force-pushed
the
add-agents-sdk
branch
2 times, most recently
from
2057390 to
fcefc53
Compare
andreibratu
changed the title
andreibratu
force-pushed
the
add-agents-sdk
branch
3 times, most recently
from
cb295f3 to
914091b
Compare
andreibratu
force-pushed
the
add-agents-sdk
branch
from
7ef38da to
911db83
Compare
src/humanloop/evals/run.py
Outdated
|
|
||
|
|
||
| def _safe_get_default_file_version(client: "BaseHumanloop", file_config: FileEvalConfig) -> EvaluatedFile: | ||
| """Get default version of a File from online workspace. |
Contributor
There was a problem hiding this comment.
nit (non-blocking): "remote" workspace?
src/humanloop/evals/run.py
Outdated
| subclient = _get_subclient(client=client, file_config=file_config) | ||
| return subclient.get(id=file_id) | ||
| else: | ||
| raise HumanloopRuntimeError("You must provide a path or id in your `file` config.") |
Contributor
There was a problem hiding this comment.
Maybe "You must provide either a path or id in your file config". Or something to indicate it's an XOR
| subclient = _get_subclient(client=client, file_config=file_config) | ||
|
|
||
| if type == "flow": | ||
| if type_ == "flow": |
Contributor
There was a problem hiding this comment.
no agent here? Why can't you upsert? From what I can tell this upserts based on the version param in eval.run?
Comment on lines
-549
to
-551
| elif type == "evaluator": | ||
| hl_file = client.evaluators.upsert(**file_dict) # type: ignore [arg-type, assignment] | ||
|
|
Contributor
There was a problem hiding this comment.
Also is removing this a breaking change?
Author
There was a problem hiding this comment.
more of some hanging code, we do not support evals.run on evaluators
src/humanloop/flows/client.py
Outdated
Comment on lines
1131
to
1137
| <<<<<<< HEAD | ||
| "2024-07-08 21:40:35+00:00", | ||
| ), | ||
| end_time=datetime.datetime.fromisoformat( | ||
| "2024-07-08 21:40:39+00:00", | ||
| ======= | ||
| "2024-07-08 19:40:35+00:00", |
Comment on lines
+119
to
+132
| def print_error(message: str) -> None: | ||
| """Print a formatted error message to stdout.""" | ||
| sys.stdout.write(f"{RED}{message}{RESET}") | ||
|
|
||
|
|
||
| def print_warning(message: str) -> None: | ||
| """Print a formatted warning message to stdout.""" | ||
| sys.stdout.write(f"{YELLOW}{message}{RESET}\n") | ||
|
|
||
|
|
||
| def print_info(message: str) -> None: | ||
| """Print a formatted info message to stdout.""" | ||
| sys.stdout.write(f"{CYAN}{message}{RESET}\n") |
Contributor
There was a problem hiding this comment.
much nicer thank you for this
jamesbaskerville
approved these changes
Apr 28, 2025
Contributor
jamesbaskerville
left a comment
jamesbaskerville
left a comment
There was a problem hiding this comment.
a few comments/possible fixes, but generally lgtm. Didn't look at all the autogenerated code, but the enum of events seems reasonable.
andreibratu
force-pushed
the
add-agents-sdk
branch
3 times, most recently
from
4ba6bb5 to
52736e3
Compare
andreibratu
force-pushed
the
add-agents-sdk
branch
from
52736e3 to
189c9d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.