Skip to content

chore: rename trace_status to log_status #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreibratu merged 1 commit into from
Mar 6, 2025
Merged

chore: rename trace_status to log_status #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/humanloop/eval_utils/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,7 @@ def _get_log_func(
"run_id": run_id,
}
if file_type == "flow":
return partial(client.flows.log, **log_request, trace_status="complete")
return partial(client.flows.log, **log_request, log_status="complete")
elif file_type == "prompt":
return partial(client.prompts.log, **log_request)
elif file_type == "evaluator":
Expand Down Expand Up @@ -912,7 +912,7 @@ def _run_local_evaluators(

# Wait for the Flow trace to complete before running evaluators
while True:
if file_type != "flow" or log_dict["trace_status"] == "complete":
if file_type != "flow" or log_dict["log_status"] == "complete":
break
log = client.logs.get(id=log_id)
if not isinstance(log, dict):
Expand Down
2 changes: 1 addition & 1 deletion src/humanloop/otel/exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ def _mark_trace_complete_if_needed(self, trace_head_span_id: int):
trace_head_span_id,
)
else:
self._client.flows.update_log(log_id=flow_log_id, trace_status="complete")
self._client.flows.update_log(log_id=flow_log_id, log_status="complete")

def _keep_track_of_trace(self, log_id: str, parent_log_id: str):
found = False
Expand Down
Loading