fix eval run progress printing by clearing line #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the leftover "0s" after done [########################################] 2/2 (100.00%) | DONE0s
peadaroh
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the leftover "0s" after done
Robin's pointed out that the progress bar completes quite quickly, but there's a significant wait after. (Which is confusing to a user because the default assumption is for the progress bar to cover the whole process, not just one part of it - i.e. why am i still waiting if the progress bar says "DONE").
I also looked into adding a "Completed generating Logs for N datapoints. Waiting for Evaluators to run and the Evaluation to complete..." print after the progress bar, but could not find a suitable place for this.