Fix: Unsafe Lookup in overloaded .log method #32
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Release 0.8.9 * update eval_utils with runs api change * ruff * clean up if condition so that url will be printed even for first run --------- Co-authored-by: fern-api <115122769+fern-api[bot]@users.noreply.github.com>
added 29 commits
November 12, 2024 11:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .log statements of the subclients are overloaded to add run_id and source_datapoint_id attributes when the log is triggered by an eval_utils run. This fixes a bug where the overloaded log doesn't check if the variable was set, which would lead to logging failing whenever an evaluation is not happening