Autofix doctype-first is now lowercase
#344
Conversation
Upgraded Prettier from 3.7.1 to 3.7.3 in package files. Added .cspell.json to .prettierignore and included .json files in the Prettier script for better formatting coverage. Also standardized DOCTYPE casing in htmlhint-server to lowercase.
coliff
changed the title
doctype-first is now lowercase
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly standardizes the DOCTYPE casing for autofixes to lowercase, aligning with Prettier v3's behavior. The changes in htmlhint-server/src/server.ts are accurate and directly implement this goal. The PR also includes valuable housekeeping tasks, such as upgrading the Prettier dependency and improving the Prettier configuration to include JSON files, which enhances overall code consistency. The changes are well-executed and I have no further recommendations.
There was a problem hiding this comment.
Pull request overview
This PR standardizes DOCTYPE declarations to lowercase (<!doctype html>) across the codebase to align with Prettier v3.x formatting standards, and upgrades Prettier from version 3.7.1 to 3.7.3.
- Updated DOCTYPE autofix functions to generate lowercase
<!doctype html>instead of uppercase<!DOCTYPE html> - Upgraded Prettier dependency from 3.7.1 to 3.7.3
- Enhanced formatting configuration by adding .json files to Prettier script and excluding .cspell.json from formatting
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated Prettier version to 3.7.3 and added .json files to prettier script formatting targets |
| package-lock.json | Updated Prettier dependency lock with version 3.7.3 and corresponding integrity hash |
| htmlhint-server/src/server.ts | Changed DOCTYPE autofix outputs from uppercase to lowercase in both createDoctypeFirstFix and createDoctypeHtml5Fix functions |
| .prettierignore | Added .cspell.json to ignore list to prevent Prettier from formatting the spell checker configuration |
standardized DOCTYPE casing in htmlhint-server to lowercase. (matches Prettier v3.x)
Also: