Skip to content

#11 Fallback to ACTION_GET_CONTENT if OPEN_DOCUMENT unsupported #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
o3661606 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#11 Fallback to ACTION_GET_CONTENT if OPEN_DOCUMENT unsupported #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions ...d/src/main/kotlin/codeux/design/filepicker/file_picker_writable/FilePickerWritableImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import android.app.Activity.RESULT_OK
import android.content.ActivityNotFoundException
import android.content.ContentResolver
import android.content.Intent
import android.content.pm.PackageManager
import android.database.Cursor
import android.net.Uri
import android.provider.OpenableColumns
Expand Down Expand Up @@ -49,16 +50,24 @@ class FilePickerWritableImpl(
throw FilePickerException("Invalid lifecycle, only one call at a time.")
}
filePickerResult = result
val intent = Intent(Intent.ACTION_OPEN_DOCUMENT).apply {
var intent = Intent(Intent.ACTION_OPEN_DOCUMENT).apply {
addCategory(Intent.CATEGORY_OPENABLE)
type = "*/*"
}
if (!intentIsValid(intent)) {
plugin.logDebug("Cannot launch file picker using Intent.ACTION_OPEN_DOCUMENT, falling back to Intent.ACTION_GET_CONTENT")
intent = Intent(Intent.ACTION_GET_CONTENT).apply {
addCategory(Intent.CATEGORY_OPENABLE)
type = "*/*"
}
}

val activity = requireActivity()
try {
activity.startActivityForResult(intent, REQUEST_CODE_OPEN_FILE)
} catch (e: ActivityNotFoundException) {
filePickerResult = null
plugin.logDebug("exception while launcing file picker", e)
plugin.logDebug("exception while launching file picker", e)
result.error(
"FilePickerNotAvailable",
"Unable to start file picker, $e",
Expand Down Expand Up @@ -86,7 +95,7 @@ class FilePickerWritableImpl(
activity.startActivityForResult(intent, REQUEST_CODE_CREATE_FILE)
} catch (e: ActivityNotFoundException) {
filePickerResult = null
plugin.logDebug("exception while launcing file picker", e)
plugin.logDebug("exception while launching file picker", e)
result.error(
"FilePickerNotAvailable",
"Unable to start file picker, $e",
Expand Down Expand Up @@ -368,4 +377,12 @@ class FilePickerWritableImpl(
}
}

@MainThread
private fun intentIsValid(intent: Intent): Boolean {
val activity = requireActivity()
val list = activity.packageManager.queryIntentActivities(intent,
PackageManager.MATCH_DEFAULT_ONLY)
return list.size > 0
}

}