Use session name when setting SID parameter #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore the original behavior by checking session cookie.
amulet1
referenced
this pull request
Dec 16, 2025
Contributor
Author
|
@TDannhauer Please merge. |
TDannhauer
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the original behavior (empty SID if session cookie is set).
Note, this (SID) is only needed for the case when browser does not allow cookies. In future we should consider removing support for session ID passed in URLs altogether due to security risks.
However currently there are multiple places where session ID is used in URLs,
PageOutput.phpis just one of them.This fixes #34.