Fixes for Arcadyan Router plus minor additions #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sorry to keep you waiting on this PR, this is on my daily list to loop back to and I have not had time, but I do want to incorporate your work! |
Author
|
No worries, @highvolt-dev! I've got it working in my environment and that's good enough for me :) I did start work on a prometheus exporter. Haven't published it but if you have interest in helping with the Nokia implementation, I'll get it out there. |
Closed
|
Please merge this in @highvolt-dev. Critical fix for showing proper band on 5G for Arcadyan router |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three Changes:
BEFORE ACCEPTING -- Third Change:
Since I am using this to monitor my Arcadyan router remotely, I don't have access to the T-Mobile App, so I wanted a way to monitor the firmware version, so I added that to the display. The issue is I don't have access to a Nokia to correctly identify the Firmware version. This will not work correctly with the Nokia. So if someone can give me the code to get the Firmware of the Nokia version, I'll incorporate it. I think that would be important before accepting this PR
Also, I can change this to merge into a different branch in the origin repo if someone can create it for me.
I'm actually debating about create a Prometheus Exporter of this data. I could add that to this program or just create my own. Let me know your thoughts.