-
Notifications
You must be signed in to change notification settings - Fork 169
feat: changing node account ids #3507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
55e9bfb to
62cb6b7
Compare
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
be6f7db to
2cf661a
Compare
Signed-off-by: venilinvasilev <venilin.vasilev@gmail.com>
Signed-off-by: venilinvasilev <venilin.vasilev@gmail.com>
Signed-off-by: venilinvasilev <venilin.vasilev@gmail.com>
Signed-off-by: venilinvasilev <venilin.vasilev@gmail.com>
Signed-off-by: venilinvasilev <venilin.vasilev@gmail.com>
Signed-off-by: venilinvasilev <venilin.vasilev@gmail.com>
Signed-off-by: venilinvasilev <venilin.vasilev@gmail.com>
Signed-off-by: venilinvasilev <venilin.vasilev@gmail.com>
Signed-off-by: venilinvasilev <venilin.vasilev@gmail.com>
1e6bf46 to
5e5fa1b
Compare
|
LGTM. Great job that you also added browser tests for that. 🙌 Won't approve it officially until we have a stable tag for that. One small thing that I would change is no need to set the client operator explicitly to 0.0.2 in the test suite itself when you can add it in the build.yml file. It's like we are doing extra steps there. |
Signed-off-by: ivaylonikolov7 <ivaylo.nikolov@limechain.tech>
venilinvasilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ivaylo Nikolov <ivaylo.nikolov@limechain.tech>
Summary
This PR implements the test plan for validating updates to the
account_idfield inNodeUpdateTransactionBodyas part of the DynamicAddress Book (DAB) enhancement. It also covers new SDK behaviors that
improve reliability when node account IDs become outdated or invalid.
Scope
Test coverage for
account_idupdatesaccount_id.SDK node-selection and retry behavior
Signing with all nodes
Ensures the SDK signs transactions with all nodes to reduce the
chance of failures caused by outdated node account IDs.
Client network refresh via mirror node
When an invalid node account error occurs, the SDK retrieves updated
network information from a mirror node and retries the transaction.
Fallback behavior without a mirror network
If no mirror node is configured, the SDK retries execution using the
next node ID in the transaction's node list until all options are
exhausted.
Alignment
The implementation aligns with the design described in:
"Changing of Node Account IDs for Nodes" (sdk-collaboration-hub#53)
Rationale
These tests ensure the robustness of Dynamic Address Book functionality,
reliable handling of account ID changes, and improved resilience in
transaction execution workflows.
Related issue(s):
#3370
Fixes #3370