Skip to content

Improve TFTypeFromOpenAPI to correctly fallback to OpenAPI when CRD lookup fails #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve TFTypeFromOpenAPI to correctly fallback to OpenAPI when CRD lookup fails #2764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion manifest/provider/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ func (ps *RawProviderServer) TFTypeFromOpenAPI(ctx context.Context, gvk schema.G
// check if GVK is from a CRD
crdSchema, err := ps.lookUpGVKinCRDs(ctx, gvk)
if err != nil {
return nil, hints, fmt.Errorf("failed to look up GVK [%s] among available CRDs: %s", gvk.String(), err)
// Log the error but don't fail - fallback to OpenAPI spec
fmt.Printf("failed to look up GVK [%s] in CRDs: %s, trying OpenAPI\n", gvk.String(), err)
crdSchema = nil // ensure fallback to OpenAPI
}
if crdSchema != nil {
js, err := json.Marshal(openapi.SchemaToSpec("", crdSchema.(map[string]interface{})))
Expand Down