Skip to content

fix/incorrect persistence leader aquire check #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2025
Merged

fix/incorrect persistence leader aquire check #30

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d2b259
fix: use current value instead of return value
stanley2058 Sep 16, 2025
cdc04ed
fix: use GET option to avoid additional call
stanley2058 Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/y-socket-io/y-socket-io.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,10 +859,13 @@ export class YSocketIO {
assert(this.client)
const redis = this.client.redis
const key = this.getLeaderKeyOf(namespace)
const ok = await redis.set(key, this.serverId, {
await redis.set(key, this.serverId, {
NX: true,
PX: PERSIST_LEADER_HEARTBEAT_INTERVAL
})

const curLeader = await redis.get(key)
const ok = curLeader === this.serverId
if (!ok) return false

this.persistentLeaderOf.add(namespace)
Expand Down