Fix descriptor search range in retrieveDescriptors() #387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
NimBLERemoteCharacteristic::retrieveDescriptors()function incorrectly uses the service's end handle (getRemoteService()->getEndHandle()) as the search range limit when discovering descriptors.This causes the following bug:
Example scenario:
Before fix: Searching descriptors for Characteristic A returns A1, A2, and B1 ❌
After fix: Searching descriptors for Characteristic A returns only A1 and A2 ✅
Solution
This PR fixes the issue by:
next_characteristic_handle - 1as the end handle for descriptor searchChanges Made
retrieveDescriptors()to iterate through service characteristicsendHandlebased on the next characteristic's handleTesting
This fix correctly handles:
Files Changed
src/NimBLERemoteCharacteristic.cpp(+18 lines, -2 lines)