Skip to content

Add a workaround for esp32s3 and esp32c3 tx power bug #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Add a workaround for esp32s3 and esp32c3 tx power bug #252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7493715
Add a workaround for esp32s3 and esp32c3 tx power bug
h2zero Dec 3, 2024
861a0c1
Move workaround to getPowerLevel and call it from getPower.
h2zero Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/NimBLEDevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,10 +425,19 @@ std::vector<NimBLEClient*> NimBLEDevice::getConnectedClients() {
# ifndef CONFIG_IDF_TARGET_ESP32P4
/**
* @brief Get the transmission power.
* @return The power level currently used in esp_power_level_t.
* @return The power level currently used in esp_power_level_t or a negative value on error.
*/
esp_power_level_t NimBLEDevice::getPowerLevel(esp_ble_power_type_t powerType) {
return esp_ble_tx_power_get(powerType);
esp_power_level_t pwr = esp_ble_tx_power_get(powerType);

# if defined(CONFIG_IDF_TARGET_ESP32C3) || defined(CONFIG_IDF_TARGET_ESP32S3)
// workaround for bug when "enhanced tx power" was added
if (pwr == 0xFF) {
pwr = esp_ble_tx_power_get(ESP_BLE_PWR_TYPE_CONN_HDL3);
}
# endif

return pwr;
} // getPowerLevel

/**
Expand Down Expand Up @@ -479,15 +488,19 @@ bool NimBLEDevice::setPower(int8_t dbm) {

/**
* @brief Get the transmission power.
* @return The power level currently used in dbm.
* @note ESP32S3 only returns 0xFF as of IDF 5, so this function will return 20dbm.
* @return The power level currently used in dbm or 0xFF on error.
*/
int NimBLEDevice::getPower() {
# ifdef ESP_PLATFORM
# ifdef CONFIG_IDF_TARGET_ESP32P4
return 0xFF; // CONFIG_IDF_TARGET_ESP32P4 does not support esp_ble_tx_power_get
# else
int pwr = esp_ble_tx_power_get(ESP_BLE_PWR_TYPE_DEFAULT);
int pwr = getPowerLevel();
if (pwr < 0) {
NIMBLE_LOGE(LOG_TAG, "esp_ble_tx_power_get failed rc=%d", pwr);
return 0xFF;
}

if (pwr < ESP_PWR_LVL_N0) {
return -3 * (ESP_PWR_LVL_N0 - pwr);
}
Expand Down
Loading