Add asynchronous client connection secure #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h2zero
reviewed
Nov 15, 2024
Owner
h2zero
left a comment
h2zero
left a comment
There was a problem hiding this comment.
Looks good, a few comments for discussion.
Owner
|
This will need to be refactored after #227 is merged, just a heads up. |
thekurtovic
force-pushed
the
feat-async-secure
branch
from
3e0e3e3 to
c8666d8
Compare
thekurtovic
force-pushed
the
feat-async-secure
branch
from
c8666d8 to
5f2730d
Compare
thekurtovic
force-pushed
the
feat-async-secure
branch
from
7ae171f to
c57ca6f
Compare
* Adds parameter `rcPtr` to `NimBLEDevice::startSecurity`, default value works as the original method. * * `rcPtr`: if not nullptr, will allow caller to obtain the internal return code. * Adds parameter `async` to `NimBLEClient::secureConnection`, default value works as the original method. * * `async`; if true, will send the secure command and return immediately with a true value for successfully sending the command, else false.
h2zero
force-pushed
the
feat-async-secure
branch
from
9196c95 to
f107061
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rcPtrtoNimBLEDevice::startSecurity, default value works as the original method.rcPtr: if not nullptr, will allow caller to obtain the internal return code.asynctoNimBLEClient::secureConnection, default value works as the original method.async; if true, will send the secure command and return immediately with a true value for successfully sending the command, else false.