Skip to content

add more parameters to TableView's renderCell function #4254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: v2_develop
Choose a base branch
from
Open

add more parameters to TableView's renderCell function #4254

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6088e9
done
metasong Sep 22, 2025
80adc5b
Merge branch 'v2_develop' into metasong/add-more-parametersj-to-table…
tig Oct 15, 2025
d135115
Merge branch 'v2_develop' into metasong/add-more-parametersj-to-table…
tig Oct 19, 2025
468a41e
Merge branch 'v2_develop' into metasong/add-more-parametersj-to-table…
tig Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Examples/UICatalog/Scenarios/MultiColouredTable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ private bool GetText (string title, string label, string initialText, out string

private class TableViewColors : TableView
{
protected override void RenderCell (Attribute cellColor, string render, bool isPrimaryCell)
protected override void RenderCell (Attribute cellColor, string render, bool isPrimaryCell, int row, int rowToRender, int columnToRender)
{
int unicorns = render.IndexOf ("unicorns", StringComparison.CurrentCultureIgnoreCase);
int rainbows = render.IndexOf ("rainbows", StringComparison.CurrentCultureIgnoreCase);
Expand Down
7 changes: 5 additions & 2 deletions Terminal.Gui/Views/TableView/TableView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1299,7 +1299,10 @@ protected virtual bool OnCellActivated (CellActivatedEventArgs args)
/// <param name="cellAttribute"></param>
/// <param name="render"></param>
/// <param name="isPrimaryCell"></param>
protected virtual void RenderCell (Attribute cellAttribute, string render, bool isPrimaryCell)
/// <param name="row"></param>
/// <param name="rowToRender"></param>
/// <param name="columnToRender"></param>
Comment on lines 1299 to +1304
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter documentation is missing descriptions. Consider adding meaningful descriptions like /// <param name="row">The logical row index in the data source</param>, /// <param name="rowToRender">The visual row position being rendered</param>, and /// <param name="columnToRender">The column index being rendered</param>.

Copilot uses AI. Check for mistakes.
protected virtual void RenderCell (Attribute cellAttribute, string render, bool isPrimaryCell, int row, int rowToRender, int columnToRender)
{
// If the cell is the selected col/row then draw the first rune in inverted colors
// this allows the user to track which cell is the active one during a multi cell
Expand Down Expand Up @@ -2003,7 +2006,7 @@ private void RenderRow (int row, int rowToRender, ColumnToRender [] columnsToRen

if (cellColor.HasValue)
{
RenderCell (cellColor.Value, render, isPrimaryCell);
RenderCell (cellColor.Value, render, isPrimaryCell, row, rowToRender, current.Column);
}

// Reset scheme to normal for drawing separators if we drew text with custom scheme
Expand Down
Loading