Skip to content

fix(ci): tidy module before linting #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
+10 −4
Merged

fix(ci): tidy module before linting #808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ test:
deps:
@echo "Running deps tidy for all modules: $(MODULES)"
for dir in $(MODULES) ; do \
echo "$${dir}"; \
echo "$${dir}"; \
cd $${dir} && go mod tidy; \
done

Expand All @@ -67,6 +67,12 @@ check-docs: $(MDOX) ## Generates code snippets and doc formatting and checks lin
@echo ">> checking docs $(PATH)"
@$(MDOX) fmt --check -l --links.validate.config-file=$(MDOX_VALIDATE_CONFIG) *.md

.PHONY: tidy_module_%
tidy_module_%:
@echo ">> running go mod tidy in $*"
@cd $* && go mod tidy
@$(call require_clean_work_tree,"tidy go.mod in $*")

.PHONY: lint
# PROTIP:
# Add
Expand Down Expand Up @@ -94,12 +100,12 @@ lint: $(BUF) $(COPYRIGHT) fmt docs
# --cpu-profile-path string Path to CPU profile output file
# --mem-profile-path string Path to memory profile output file
# to debug big allocations during linting.
lint_module_%: ## Runs various static analysis against our code.
lint_module_%: tidy_module_% ## Runs various static analysis against our code.
$(MODULES:%=lint_module_%): lint_module_%: $(GOLANGCI_LINT) $(MISSPELL)

@echo ">> examining all of the Go files"
@cd $* && go vet -stdmethods=false ./...

@echo ">> linting all of the Go files GOGC=${GOGC}"
@cd $* && $(GOLANGCI_LINT) run
@$(call require_clean_work_tree,"golangci lint")
Expand Down